ineanto/nicko
1
0
Fork 0
Code Issues Pull requests Activity

refactor(i18n): shorter keys

Browse source
This commit is contained in:
ineanto 2023-06-29 11:13:16 +02:00
parent cb11f5e47a
commit 02e03794e4
5 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/main/java/xyz/atnrch/nicko/disguise/AppearanceManager.java
View file

@ -142,9 +142,9 @@ public class AppearanceManager {
}
return new ActionResult<>();
} catch (ExecutionException e) {
return new ActionResult<>(I18NDict.Error.SKIN_FAIL_CACHE);
return new ActionResult<>(I18NDict.Error.CACHE);
} catch (IOException e) {
return new ActionResult<>(I18NDict.Error.NAME_FAIL_MOJANG);
return new ActionResult<>(I18NDict.Error.MOJANG_NAME);
}
}
return new ActionResult<>();

10
src/main/java/xyz/atnrch/nicko/i18n/I18NDict.java
View file

@ -24,11 +24,11 @@ public class I18NDict {
}
public static class Error {
public static final String UNEXPECTED_ERROR = "error.invalid_name";
public static final String PLAYER_OFFLINE = "error.player_offline";
public static final String SKIN_FAIL_MOJANG = "error.couldnt_get_skin_from_mojang";
public static final String SKIN_FAIL_CACHE = "error.couldnt_get_skin_from_cache";
public static final String NAME_FAIL_MOJANG = "error.couldnt_get_name_from_mojang";
public static final String GENERIC = "error.generic";
public static final String PLAYER_OFFLINE = "error.offline";
public static final String CACHE = "error.cache";
public static final String MOJANG_NAME = "error.mojang_name";
public static final String MOJANG_SKIN = "error.mojang_skin";
public static final String INVALID_USERNAME = "error.invalid_username";
public static final String SQL_ERROR = "error.sql";
public static final String JSON_ERROR = "error.json";

6
src/main/java/xyz/atnrch/nicko/storage/PlayerDataStore.java
View file

@ -63,10 +63,10 @@ public class PlayerDataStore {
}
public ActionResult<Void> saveData(Player player) {
if (storage.isError()) return new ActionResult<>(I18NDict.Error.UNEXPECTED_ERROR);
if (!cache.isCached(player.getUniqueId())) return new ActionResult<>(I18NDict.Error.UNEXPECTED_ERROR);
if (storage.isError()) return new ActionResult<>(I18NDict.Error.GENERIC);
if (!cache.isCached(player.getUniqueId())) return new ActionResult<>(I18NDict.Error.GENERIC);
if (!cache.retrieve(player.getUniqueId()).isPresent())
return new ActionResult<>(I18NDict.Error.UNEXPECTED_ERROR);
return new ActionResult<>(I18NDict.Error.GENERIC);
// TODO (Ineanto, 5/20/23): Remove value from cache
//profiles.remove(player.getUniqueId());