diff --git a/src/main/java/xyz/ineanto/nicko/appearance/random/RandomNameFetcher.java b/src/main/java/xyz/ineanto/nicko/appearance/random/RandomNameFetcher.java index 0557047..b6778a4 100644 --- a/src/main/java/xyz/ineanto/nicko/appearance/random/RandomNameFetcher.java +++ b/src/main/java/xyz/ineanto/nicko/appearance/random/RandomNameFetcher.java @@ -24,13 +24,13 @@ public class RandomNameFetcher { try (BufferedReader reader = new BufferedReader(new InputStreamReader(resource))) { String line; while ((line = reader.readLine()) != null) { - String[] values = line.split("\n"); + final String[] values = line.split("\n"); records.add(Arrays.asList(values)); } } catch (IOException e) { throw new RuntimeException(e); } - return records.get(new Random().nextInt(records.size() -1)).get(0); + return records.get(new Random().nextInt(records.size() - 1)).get(0); } } diff --git a/src/test/java/xyz/ineanto/nicko/test/appearance/RandomNameTest.java b/src/test/java/xyz/ineanto/nicko/test/appearance/RandomNameTest.java index c5486b6..008dcca 100644 --- a/src/test/java/xyz/ineanto/nicko/test/appearance/RandomNameTest.java +++ b/src/test/java/xyz/ineanto/nicko/test/appearance/RandomNameTest.java @@ -8,8 +8,9 @@ import org.junit.jupiter.api.Test; import xyz.ineanto.nicko.NickoBukkit; import xyz.ineanto.nicko.appearance.random.RandomNameFetcher; import xyz.ineanto.nicko.config.Configuration; +import xyz.ineanto.nicko.mojang.MojangUtils; -import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.*; public class RandomNameTest { private static NickoBukkit plugin; @@ -25,7 +26,9 @@ public class RandomNameTest { @DisplayName("Get random name") public void getRandomName() { final RandomNameFetcher randomNameFetcher = new RandomNameFetcher(plugin); - assertNotNull(randomNameFetcher.getRandomUsername()); + final String username = randomNameFetcher.getRandomUsername(); + assertNotNull(username); + assertFalse(MojangUtils.isUsernameInvalid(username)); } @AfterAll