From 1eb2af64435536e070b4aed74d44838da0d975c1 Mon Sep 17 00:00:00 2001 From: ineanto Date: Fri, 28 Apr 2023 23:52:50 +0200 Subject: [PATCH] why mojang? why? --- logs/2023-04-28-1.log.gz | Bin 0 -> 124 bytes logs/2023-04-28-2.log.gz | Bin 0 -> 124 bytes logs/2023-04-28-3.log.gz | Bin 0 -> 124 bytes logs/2023-04-28-4.log.gz | Bin 0 -> 124 bytes .../net/artelnatif/nicko/NickoBukkit.java | 35 ------------------ .../nicko/disguise/AppearanceManager.java | 7 ++-- .../wrapper/WrapperPlayServerRespawn.java | 11 +++--- 7 files changed, 8 insertions(+), 45 deletions(-) create mode 100644 logs/2023-04-28-1.log.gz create mode 100644 logs/2023-04-28-2.log.gz create mode 100644 logs/2023-04-28-3.log.gz create mode 100644 logs/2023-04-28-4.log.gz diff --git a/logs/2023-04-28-1.log.gz b/logs/2023-04-28-1.log.gz new file mode 100644 index 0000000000000000000000000000000000000000..759f46fbeca47326703aefd30fbfc09ca76b77bb GIT binary patch literal 124 zcmV-?0E7P@iwFP!00000{{_LZ4uUWc2H@SN__xYntfeI8CK+5YVPPN)O=XzV^&4Vwd8~+3wF%{Bg~t*nU!N$ e->jR#ao18`_y*MkPb literal 0 HcmV?d00001 diff --git a/logs/2023-04-28-2.log.gz b/logs/2023-04-28-2.log.gz new file mode 100644 index 0000000000000000000000000000000000000000..5236e1ca399a45b94bd4c6ef77c09d5aa71116d5 GIT binary patch literal 124 zcmV-?0E7P@iwFP!00000{{_LZ4uUWc2H@SN__yj{tVI%X6AZ4HxHu4ormfPX_RJlG z*Z2D-*HF`v>t;+}pX=o{Jja=E7hxe>?X5k#&RR-&9k({kH!O$+9a&*l6W?$g2;RYe&!U9P95BO=BSLNY^4C8vm|D0WK6 literal 0 HcmV?d00001 diff --git a/logs/2023-04-28-4.log.gz b/logs/2023-04-28-4.log.gz new file mode 100644 index 0000000000000000000000000000000000000000..a6f5e76a2d21c295ccf47564184c7da70dfb0584 GIT binary patch literal 124 zcmb2|=3oGW|Evc$@--O4FumQ>9kC?jql4%U#t2>Q6=<9NKseC=7h^C28Z^{njLBJBQ-6S c_myw)&j-&#%cprr$hE)X*NHi!kp;9A03zErZvX%Q literal 0 HcmV?d00001 diff --git a/src/main/java/net/artelnatif/nicko/NickoBukkit.java b/src/main/java/net/artelnatif/nicko/NickoBukkit.java index 641b86b..8310406 100644 --- a/src/main/java/net/artelnatif/nicko/NickoBukkit.java +++ b/src/main/java/net/artelnatif/nicko/NickoBukkit.java @@ -1,12 +1,7 @@ package net.artelnatif.nicko; -import com.comphenix.protocol.PacketType; import com.comphenix.protocol.ProtocolLibrary; import com.comphenix.protocol.ProtocolManager; -import com.comphenix.protocol.events.ListenerPriority; -import com.comphenix.protocol.events.PacketAdapter; -import com.comphenix.protocol.events.PacketContainer; -import com.comphenix.protocol.events.PacketEvent; import net.artelnatif.nicko.command.NickoCommand; import net.artelnatif.nicko.config.Configuration; import net.artelnatif.nicko.config.ConfigurationManager; @@ -20,7 +15,6 @@ import net.artelnatif.nicko.mojang.MojangAPI; import net.artelnatif.nicko.placeholder.PlaceHolderHook; import net.artelnatif.nicko.storage.PlayerDataStore; import net.artelnatif.nicko.storage.name.PlayerNameStore; -import net.artelnatif.nicko.wrapper.WrapperPlayServerRespawn; import org.bukkit.Bukkit; import org.bukkit.Material; import org.bukkit.command.PluginCommand; @@ -110,35 +104,6 @@ public class NickoBukkit extends JavaPlugin { getServer().getPluginManager().registerEvents(new PlayerJoinListener(), this); getServer().getPluginManager().registerEvents(new PlayerQuitListener(), this); - // For debug purposes - protocolManager.addPacketListener(new PacketAdapter( - this, - ListenerPriority.NORMAL, - PacketType.Play.Server.RESPAWN) { - @Override - public void onPacketReceiving(PacketEvent event) { - } - - @Override - public void onPacketSending(PacketEvent event) { - final PacketContainer packet = event.getPacket(); - final WrapperPlayServerRespawn respawn = new WrapperPlayServerRespawn(packet); - getLogger().info(respawn.getDimension().getName()); - getLogger().info(String.valueOf(respawn.isCopyMetadata())); - getLogger().info(String.valueOf(respawn.getSeed())); - getLogger().info(String.valueOf(respawn.getLastDeathLocation().isPresent())); - /** - * packet.getStructures().getFields().forEach(fieldAccessor -> { - * final Field field = fieldAccessor.getField(); - * getLogger().info("field=[" + - * "name=" + field.getName() + "," + - * "type=" + field.getType().getSimpleName() + - * "]"); - * }); - */ - } - }); - getLogger().info("Nicko (Bukkit) has been enabled."); } } diff --git a/src/main/java/net/artelnatif/nicko/disguise/AppearanceManager.java b/src/main/java/net/artelnatif/nicko/disguise/AppearanceManager.java index 93e3841..c8f3ec2 100644 --- a/src/main/java/net/artelnatif/nicko/disguise/AppearanceManager.java +++ b/src/main/java/net/artelnatif/nicko/disguise/AppearanceManager.java @@ -142,16 +142,15 @@ public class AppearanceManager { final World world = player.getWorld(); final WrapperPlayServerRespawn respawn = new WrapperPlayServerRespawn(); + respawn.setDimension(world); + respawn.setSeed(world.getSeed()); respawn.setGameMode(player.getGameMode()); respawn.setPreviousGameMode(player.getGameMode()); respawn.setDifficulty(world.getDifficulty()); - respawn.setDimension(world); - respawn.setSeed(world.getSeed()); - respawn.setLastDeathLocation(player.getLocation()); respawn.setCopyMetadata(false); respawn.getHandle().getBooleans().write(0, false); // is debug respawn.getHandle().getBooleans().write(1, false); // is flat - respawn.sendPacket(player); + respawn.broadcastPacket(); /*final EntityPlayer cp = ((CraftPlayer) player).getHandle(); final PacketPlayOutRespawn respawn = new PacketPlayOutRespawn(cp.cG().Z(), cp.P(), player.getWorld().getSeed(), EnumGamemode.a, EnumGamemode.a, true, true, (byte) 0x00, Optional.empty()); cp.b.a(respawn);*/ diff --git a/src/main/java/net/artelnatif/nicko/wrapper/WrapperPlayServerRespawn.java b/src/main/java/net/artelnatif/nicko/wrapper/WrapperPlayServerRespawn.java index a8a855a..e43c6cb 100644 --- a/src/main/java/net/artelnatif/nicko/wrapper/WrapperPlayServerRespawn.java +++ b/src/main/java/net/artelnatif/nicko/wrapper/WrapperPlayServerRespawn.java @@ -26,8 +26,6 @@ public class WrapperPlayServerRespawn extends AbstractPacket { handle.getModifier().writeDefaults(); } - public WrapperPlayServerRespawn(PacketContainer container) { super(container, TYPE); } - //............. // Dimension Field (1.8 - Present) // The dimension field has changed numerous times: @@ -62,8 +60,8 @@ public class WrapperPlayServerRespawn extends AbstractPacket { // GameMode Field //............. - public void getGameMode() { - handle.getGameModes().read(0); + public GameMode getGameMode() { + return handle.getGameModes().read(0).toBukkit(); } public void setGameMode(GameMode value) { @@ -74,8 +72,8 @@ public class WrapperPlayServerRespawn extends AbstractPacket { // Previous GameMode Field //............. - public void getPreviousGameMode() { - handle.getGameModes().read(1); + public GameMode getPreviousGameMode() { + return handle.getGameModes().read(1).toBukkit(); } public void setPreviousGameMode(GameMode value) { @@ -97,6 +95,7 @@ public class WrapperPlayServerRespawn extends AbstractPacket { //............. // Last death location Field // Added in 1.19. + // (useless?) //............. public Optional getLastDeathLocation() {