From 666c45735db43f169e05e7a8eda8d3633a1a2196 Mon Sep 17 00:00:00 2001 From: ineanto Date: Sun, 8 Jun 2025 09:16:39 +0200 Subject: [PATCH] fix(favorites): wrong values when item create --- .../gui/items/favorites/FavoriteAppearanceEntryItem.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/xyz/ineanto/nicko/gui/items/favorites/FavoriteAppearanceEntryItem.java b/src/main/java/xyz/ineanto/nicko/gui/items/favorites/FavoriteAppearanceEntryItem.java index e92abcc..62c84d3 100644 --- a/src/main/java/xyz/ineanto/nicko/gui/items/favorites/FavoriteAppearanceEntryItem.java +++ b/src/main/java/xyz/ineanto/nicko/gui/items/favorites/FavoriteAppearanceEntryItem.java @@ -33,13 +33,14 @@ public class FavoriteAppearanceEntryItem extends AsyncItem { }, (_ -> true)).getItemProvider(), () -> { try { - final String name = (appearance.name() == null ? appearance.skin() : appearance.name()); - final String skin = (appearance.skin() == null ? appearance.name() : appearance.skin()); + // TODO (Ineanto, 08/06/2025): set a default skin if the entry contains only a name + final String name = (appearance.name() == null ? "N/A" : appearance.name()); + final String skin = (appearance.skin() == null ? "N/A" : appearance.skin()); final SkullBuilder skull = new SkullBuilder(skin); return playerLanguage.translateItem(skull, LanguageKey.GUI.Admin.Cache.ENTRY, name); } catch (MojangApiUtils.MojangApiException | IOException e) { Nicko.getInstance().getLogger().warning("Unable to get Head texture for specified UUID (" + appearance.skin() + ")! (GUI/Favorites/Entry)"); - return ItemDefaults.getErrorSkullItem(playerLanguage, LanguageKey.GUI.Admin.Cache.ENTRY, Nicko.getInstance().getMojangAPI().getUUIDName("Notch")); + return ItemDefaults.getErrorSkullItem(playerLanguage, LanguageKey.GUI.Admin.Cache.ENTRY, "..."); } }); this.playerLanguage = playerLanguage;