From 875dcebe0b1987d716009e6cec4d00091168e832 Mon Sep 17 00:00:00 2001
From: aro <pantoine.rochas@gmail.com>
Date: Tue, 14 Mar 2023 09:41:30 +0100
Subject: [PATCH] fix(config): add default constructor and actually test

---
 bugs.txt                                                 | 1 +
 core/src/main/java/net/artelnatif/nicko/NickoBukkit.java | 7 +++++++
 .../artelnatif/nicko/config/DataSourceConfiguration.java | 2 ++
 .../artelnatif/nicko/test/config/ConfigurationTest.java  | 9 +--------
 4 files changed, 11 insertions(+), 8 deletions(-)
 create mode 100644 bugs.txt

diff --git a/bugs.txt b/bugs.txt
new file mode 100644
index 0000000..81e53b1
--- /dev/null
+++ b/bugs.txt
@@ -0,0 +1 @@
+Item cycle is broken
\ No newline at end of file
diff --git a/core/src/main/java/net/artelnatif/nicko/NickoBukkit.java b/core/src/main/java/net/artelnatif/nicko/NickoBukkit.java
index b4caaf1..b080349 100644
--- a/core/src/main/java/net/artelnatif/nicko/NickoBukkit.java
+++ b/core/src/main/java/net/artelnatif/nicko/NickoBukkit.java
@@ -41,6 +41,13 @@ public class NickoBukkit extends JavaPlugin {
 
     public NickoBukkit() { this.unitTesting = false; }
 
+    /**
+     * Used by MockBukkit
+     */
+    protected NickoBukkit(JavaPluginLoader loader, PluginDescriptionFile description, File dataFolder, File file) {
+        this(loader, description, dataFolder, file, null);
+    }
+
     /**
      * Used by MockBukkit
      */
diff --git a/core/src/main/java/net/artelnatif/nicko/config/DataSourceConfiguration.java b/core/src/main/java/net/artelnatif/nicko/config/DataSourceConfiguration.java
index 5778416..d180824 100644
--- a/core/src/main/java/net/artelnatif/nicko/config/DataSourceConfiguration.java
+++ b/core/src/main/java/net/artelnatif/nicko/config/DataSourceConfiguration.java
@@ -16,6 +16,8 @@ public class DataSourceConfiguration {
         this.password = password;
     }
 
+    public DataSourceConfiguration() { this("", 0, "", ""); }
+
     public String getAddress() {
         return address;
     }
diff --git a/core/src/test/java/net/artelnatif/nicko/test/config/ConfigurationTest.java b/core/src/test/java/net/artelnatif/nicko/test/config/ConfigurationTest.java
index d61dcd7..8c461c8 100644
--- a/core/src/test/java/net/artelnatif/nicko/test/config/ConfigurationTest.java
+++ b/core/src/test/java/net/artelnatif/nicko/test/config/ConfigurationTest.java
@@ -3,7 +3,6 @@ package net.artelnatif.nicko.test.config;
 import be.seeseemelk.mockbukkit.MockBukkit;
 import net.artelnatif.nicko.NickoBukkit;
 import net.artelnatif.nicko.config.Configuration;
-import net.artelnatif.nicko.config.DataSourceConfiguration;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.DisplayName;
@@ -16,14 +15,8 @@ public class ConfigurationTest {
 
     @BeforeAll
     public static void setup() {
-        final Configuration config = new Configuration(
-                DataSourceConfiguration.SQL_EMPTY,
-                DataSourceConfiguration.REDIS_EMPTY,
-                "",
-                true,
-                false);
         MockBukkit.mock();
-        plugin = MockBukkit.load(NickoBukkit.class, config);
+        plugin = MockBukkit.load(NickoBukkit.class);
     }
 
     @Test