From 8dfdbd4db3ff7c802bf6bc251cac463098dac882 Mon Sep 17 00:00:00 2001 From: aro Date: Fri, 20 Jan 2023 12:58:27 +0100 Subject: [PATCH] refactor(item): descriptions and naming --- .../nicko/gui/items/admin/cache/CacheDetailed.java | 4 ++-- .../gui/items/admin/cache/CacheInvalidate.java | 6 +++--- .../nicko/gui/items/admin/cache/CacheOverview.java | 13 ++++--------- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheDetailed.java b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheDetailed.java index ab5ec0c..2b81e3a 100644 --- a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheDetailed.java +++ b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheDetailed.java @@ -13,9 +13,9 @@ import org.jetbrains.annotations.NotNull; public class CacheDetailed extends BaseItem { @Override public ItemProvider getItemProvider() { - final ItemBuilder builder = new ItemBuilder(Material.ARROW); + final ItemBuilder builder = new ItemBuilder(Material.PAPER); builder.setDisplayName("§6Invalidate specific skin..."); - builder.addLoreLines("§7PLACEHOLDER REPLACE ME"); + builder.addLoreLines("§7Select a specific skin to invalidate."); return builder; } diff --git a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheInvalidate.java b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheInvalidate.java index 3d31a8f..f5ba3f2 100644 --- a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheInvalidate.java +++ b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheInvalidate.java @@ -16,11 +16,11 @@ public class CacheInvalidate extends BaseItem { @Override public ItemProvider getItemProvider() { final ItemBuilder builder = new ItemBuilder(Material.TNT); - builder.setDisplayName("§6Invalidate the full Skin Cache"); + builder.setDisplayName("§6Invalidate §fskin cache"); builder.addLoreLines( "§c§oNOT RECOMMENDED", - "§7Invalidate every skin entry present in the cache,", - "§7without resetting player disguises.", + "§7Invalidates every skin entry present in the cache.", + "§7Does not reset player disguises.", "§7Could be useful if a skin has been updated", "§7recently and the cache is now outdated."); return builder; diff --git a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheOverview.java b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheOverview.java index d9cd54b..e09b64d 100644 --- a/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheOverview.java +++ b/nicko-core/src/main/java/net/artelnatif/nicko/gui/items/admin/cache/CacheOverview.java @@ -8,11 +8,9 @@ import de.studiocode.invui.item.impl.BaseItem; import net.artelnatif.nicko.NickoBukkit; import net.artelnatif.nicko.mojang.MojangSkin; import org.bukkit.Material; -import org.bukkit.enchantments.Enchantment; import org.bukkit.entity.Player; import org.bukkit.event.inventory.ClickType; import org.bukkit.event.inventory.InventoryClickEvent; -import org.bukkit.inventory.ItemFlag; import org.jetbrains.annotations.NotNull; import java.util.Optional; @@ -23,14 +21,11 @@ public class CacheOverview extends BaseItem { final ItemBuilder builder = new ItemBuilder(Material.OAK_SIGN); final LoadingCache> cache = NickoBukkit.getInstance().getMojangAPI().getCache(); final CacheStats stats = cache.stats(); - builder.addEnchantment(Enchantment.DAMAGE_ALL, 1, false); - builder.addItemFlags(ItemFlag.HIDE_ENCHANTS); - builder.setDisplayName("§6Skin Cache overview:"); + builder.setDisplayName("§6Skin cache §foverview:"); builder.addLoreLines( - "§d§oCache is cleared every 24 hours.", - "§6Average Load Penalty: §d" + Math.round(stats.averageLoadPenalty()), - "§6Request Count: §d" + stats.requestCount(), - "§6Skin Cached: §d" + Math.round(cache.size()), + "Request Count: §2" + stats.requestCount(), + "Skin Cached: §2" + Math.round(cache.size()), + "§7§oCache is cleared every 24 hours.", "§7§o(Click to refresh)"); return builder; }