From 95cb60a6b3f185caea786ed903e33e19c3459a0b Mon Sep 17 00:00:00 2001 From: ineanto Date: Thu, 23 Nov 2023 23:21:15 +0100 Subject: [PATCH] fix(chat validation): it works! Chat Sessions are not invalidated anymore after disguised. --- .../atnrch/nicko/appearance/AppearanceManager.java | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/main/java/xyz/atnrch/nicko/appearance/AppearanceManager.java b/src/main/java/xyz/atnrch/nicko/appearance/AppearanceManager.java index 91172b3..f9bab11 100644 --- a/src/main/java/xyz/atnrch/nicko/appearance/AppearanceManager.java +++ b/src/main/java/xyz/atnrch/nicko/appearance/AppearanceManager.java @@ -158,22 +158,14 @@ public class AppearanceManager { remove.broadcastPacket(); } - // Yes, I skip providing chat session data. - // Yes, this will cause players to get kicked - // as soon as they send a message on versions above 1.19.2. - // No, I'll not waste another day fixing their mess. - // Go cry about it to Mojang. - // (Long live NoEncryption!) - // TODO (Ineanto, 9/1/23): - // Try to provide chat session data after ProtocolLib's update to support Chat Sessions. - // This could remove the mandatory NoEncryption (or similar "encryption removing") dependency with Nicko. add.setData(ImmutableList.of(new PlayerInfoData( player.getUniqueId(), player.getPing(), true, EnumWrappers.NativeGameMode.fromBukkit(player.getGameMode()), gameProfile, - WrappedChatComponent.fromText(displayName) + WrappedChatComponent.fromText(displayName), + WrappedRemoteChatSessionData.fromPlayer(player) ))); add.broadcastPacket(); }