From e7bd920e92d213b666119c0abf0381fd00872927 Mon Sep 17 00:00:00 2001 From: aro Date: Sat, 11 Mar 2023 11:41:23 +0100 Subject: [PATCH] refactor: static imports --- .../nicko/test/cache/CacheStorageTest.java | 45 +++++++++++++++++++ .../nicko/test/storage/BrokenSQLTest.java | 11 +++-- .../nicko/test/storage/SQLStorageTest.java | 25 ++++++----- 3 files changed, 66 insertions(+), 15 deletions(-) create mode 100644 core/src/test/java/net/artelnatif/nicko/test/cache/CacheStorageTest.java diff --git a/core/src/test/java/net/artelnatif/nicko/test/cache/CacheStorageTest.java b/core/src/test/java/net/artelnatif/nicko/test/cache/CacheStorageTest.java new file mode 100644 index 0000000..e130b84 --- /dev/null +++ b/core/src/test/java/net/artelnatif/nicko/test/cache/CacheStorageTest.java @@ -0,0 +1,45 @@ +package net.artelnatif.nicko.test.cache; + +import be.seeseemelk.mockbukkit.MockBukkit; +import be.seeseemelk.mockbukkit.ServerMock; +import be.seeseemelk.mockbukkit.entity.PlayerMock; +import net.artelnatif.nicko.NickoBukkit; +import net.artelnatif.nicko.config.Configuration; +import net.artelnatif.nicko.disguise.NickoProfile; +import org.junit.jupiter.api.*; + +import java.util.Optional; + +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class CacheStorageTest { + private static ServerMock server; + private static NickoBukkit plugin; + private static PlayerMock player; + + @BeforeAll + public static void setup() { + final Configuration config = new Configuration( + "127.0.0.1", + "root", + "INVALID_PASSWORD", + "", + false, + false); + server = MockBukkit.mock(); + plugin = MockBukkit.load(NickoBukkit.class, config); + player = server.addPlayer(); + } + + @Test + @DisplayName("Cache Player Data") + public void cachePlayerData() { + final Optional optionalProfile = plugin.getDataStore().getData(player.getUniqueId()); + assertTrue(optionalProfile.isPresent()); + } + + @AfterAll + public static void shutdown() { + MockBukkit.unmock(); + } +} diff --git a/core/src/test/java/net/artelnatif/nicko/test/storage/BrokenSQLTest.java b/core/src/test/java/net/artelnatif/nicko/test/storage/BrokenSQLTest.java index c75695c..3e4e069 100644 --- a/core/src/test/java/net/artelnatif/nicko/test/storage/BrokenSQLTest.java +++ b/core/src/test/java/net/artelnatif/nicko/test/storage/BrokenSQLTest.java @@ -11,6 +11,9 @@ import org.junit.jupiter.api.*; import java.util.Optional; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + public class BrokenSQLTest { private static ServerMock server; private static NickoBukkit plugin; @@ -33,23 +36,23 @@ public class BrokenSQLTest { @Test @DisplayName("Fail to create Tables") public void createSQLTables() { - Assertions.assertTrue(plugin.getDataStore().getStorage().isError()); + assertTrue(plugin.getDataStore().getStorage().isError()); } @Test @DisplayName("Fail to Store Player Via SQL") public void storePlayer() { final Optional optionalProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertFalse(optionalProfile.isPresent()); + assertFalse(optionalProfile.isPresent()); ActionResult result = plugin.getDataStore().saveData(player); - Assertions.assertTrue(result.isError()); + assertTrue(result.isError()); } @Test @DisplayName("Fail to Retrieve Player Via SQL") public void retrievePlayer() { final Optional storeAction = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertFalse(storeAction.isPresent()); + assertFalse(storeAction.isPresent()); } @AfterAll diff --git a/core/src/test/java/net/artelnatif/nicko/test/storage/SQLStorageTest.java b/core/src/test/java/net/artelnatif/nicko/test/storage/SQLStorageTest.java index 608c801..d443668 100644 --- a/core/src/test/java/net/artelnatif/nicko/test/storage/SQLStorageTest.java +++ b/core/src/test/java/net/artelnatif/nicko/test/storage/SQLStorageTest.java @@ -12,6 +12,9 @@ import org.junit.jupiter.api.*; import java.util.Optional; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + @TestMethodOrder(MethodOrderer.OrderAnnotation.class) public class SQLStorageTest { private static ServerMock server; @@ -36,7 +39,7 @@ public class SQLStorageTest { @DisplayName("Create SQL Tables") @Order(1) public void createSQLTables() { - Assertions.assertFalse(plugin.getDataStore().getStorage().isError()); + assertFalse(plugin.getDataStore().getStorage().isError()); } @Test @@ -44,7 +47,7 @@ public class SQLStorageTest { @Order(2) public void storePlayer() { final Optional optionalProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(optionalProfile.isPresent()); + assertTrue(optionalProfile.isPresent()); } @Test @@ -52,7 +55,7 @@ public class SQLStorageTest { @Order(3) public void retrievePlayer() { final Optional storeAction = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(storeAction.isPresent()); + assertTrue(storeAction.isPresent()); } @Test @@ -60,13 +63,13 @@ public class SQLStorageTest { @Order(4) public void updatePlayer() { final Optional optionalProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(optionalProfile.isPresent()); + assertTrue(optionalProfile.isPresent()); final NickoProfile profile = optionalProfile.get(); Assertions.assertNull(profile.getName()); Assertions.assertNull(profile.getSkin()); Assertions.assertEquals(profile.getLocale(), Locale.ENGLISH); - Assertions.assertTrue(profile.isBungeecordTransfer()); + assertTrue(profile.isBungeecordTransfer()); profile.setName("Notch"); profile.setSkin("Notch"); @@ -74,15 +77,15 @@ public class SQLStorageTest { profile.setBungeecordTransfer(false); final ActionResult result = plugin.getDataStore().saveData(player); - Assertions.assertFalse(result.isError()); + assertFalse(result.isError()); final Optional optionalUpdatedProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(optionalUpdatedProfile.isPresent()); + assertTrue(optionalUpdatedProfile.isPresent()); final NickoProfile updatedProfile = optionalProfile.get(); Assertions.assertEquals(updatedProfile.getName(), "Notch"); Assertions.assertEquals(updatedProfile.getSkin(), "Notch"); Assertions.assertEquals(updatedProfile.getLocale(), Locale.FRENCH); - Assertions.assertFalse(updatedProfile.isBungeecordTransfer()); + assertFalse(updatedProfile.isBungeecordTransfer()); } @Test @@ -90,7 +93,7 @@ public class SQLStorageTest { @Order(5) public void removePlayerDisguise() { final Optional optionalProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(optionalProfile.isPresent()); + assertTrue(optionalProfile.isPresent()); final NickoProfile profile = optionalProfile.get(); @@ -98,10 +101,10 @@ public class SQLStorageTest { profile.setSkin(null); final ActionResult result = plugin.getDataStore().saveData(player); - Assertions.assertFalse(result.isError()); + assertFalse(result.isError()); final Optional optionalUpdatedProfile = plugin.getDataStore().getData(player.getUniqueId()); - Assertions.assertTrue(optionalUpdatedProfile.isPresent()); + assertTrue(optionalUpdatedProfile.isPresent()); final NickoProfile updatedProfile = optionalProfile.get(); Assertions.assertNull(updatedProfile.getName()); Assertions.assertNull(updatedProfile.getSkin());