ineanto/nicko
1
0
Fork 0
Code Issues Pull requests Activity

style: better code naming/conventions for player check

Browse source
This commit is contained in:
aro 2023-01-16 18:28:36 +01:00
parent 42439019b7
commit ee8fc04d4a
3 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
nicko-core/src/main/java/net/artelnatif/nicko/command/sub/NickoCheckSubCmd.java
View file

@ -5,7 +5,6 @@ import net.artelnatif.nicko.disguise.AppearanceManager;
import net.artelnatif.nicko.i18n.I18N; import net.artelnatif.nicko.i18n.I18N;
import net.artelnatif.nicko.i18n.I18NDict; import net.artelnatif.nicko.i18n.I18NDict;
import net.artelnatif.nicko.mojang.MojangUtils; import net.artelnatif.nicko.mojang.MojangUtils;
import net.artelnatif.nicko.utils.PlayerUtils;
import org.bukkit.Bukkit; import org.bukkit.Bukkit;
import org.bukkit.entity.Player; import org.bukkit.entity.Player;
@ -22,7 +21,7 @@ public class NickoCheckSubCmd {
return; return;
} }
if (PlayerUtils.isPlayerOffline(target)) { if (target == null) {
appearanceManager = AppearanceManager.get(targetName); appearanceManager = AppearanceManager.get(targetName);
} else { } else {
appearanceManager = AppearanceManager.get(target); appearanceManager = AppearanceManager.get(target);

3
nicko-core/src/main/java/net/artelnatif/nicko/command/sub/NickoDebugSubCmd.java
View file

@ -3,7 +3,6 @@ package net.artelnatif.nicko.command.sub;
import net.artelnatif.nicko.NickoBukkit; import net.artelnatif.nicko.NickoBukkit;
import net.artelnatif.nicko.disguise.AppearanceManager; import net.artelnatif.nicko.disguise.AppearanceManager;
import net.artelnatif.nicko.mojang.MojangUtils; import net.artelnatif.nicko.mojang.MojangUtils;
import net.artelnatif.nicko.utils.PlayerUtils;
import org.bukkit.Bukkit; import org.bukkit.Bukkit;
import org.bukkit.Sound; import org.bukkit.Sound;
import org.bukkit.command.CommandSender; import org.bukkit.command.CommandSender;
@ -28,7 +27,7 @@ public class NickoDebugSubCmd {
name = args[2]; name = args[2];
skin = args[3]; skin = args[3];
if (PlayerUtils.isPlayerOffline(target)) { if (target == null) {
sender.sendMessage(NickoBukkit.getInstance().getNickoConfig().getPrefix() + "§cSpecified player is offline."); sender.sendMessage(NickoBukkit.getInstance().getNickoConfig().getPrefix() + "§cSpecified player is offline.");
return; return;
} }

9
nicko-core/src/main/java/net/artelnatif/nicko/utils/PlayerUtils.java
View file

@ -1,9 +0,0 @@
package net.artelnatif.nicko.utils;
import org.bukkit.entity.Player;
public class PlayerUtils {
public static boolean isPlayerOffline(Player player) {
return player == null || !player.isOnline();
}
}