From c20df8bc489aca9b71a7ca06fcc5f16b63309895 Mon Sep 17 00:00:00 2001 From: ineanto Date: Mon, 30 Jun 2025 22:01:49 +0200 Subject: [PATCH 1/2] fix(appearance): fix player destroy/create --- .../xyz/ineanto/nicko/appearance/AppearanceManager.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java b/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java index 0eece57..0624784 100644 --- a/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java +++ b/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java @@ -54,17 +54,24 @@ public class AppearanceManager { if (skinChange) { final ActionResult propertiesUpdateResult = packetSender.updatePlayerProfileProperties(); + System.out.println(player.getPlayerProfile().getName()); + if (propertiesUpdateResult.isError()) { return resetWithoutUpdate(); } } + // Not needed, but still broken using PE. + //packetSender.sendPlayerRespawn(); + // Call the event. final PlayerDisguiseEvent event = new PlayerDisguiseEvent(player, profile.getSkin(), profile.getName()); Bukkit.getPluginManager().callEvent(event); packetSender.sendEntityMetadataUpdate(); packetSender.sendTabListUpdate(displayName); + + packetSender.sendEntityRespawn(); return result; } From 42f94769704bcef319d153192451200a4aa52d21 Mon Sep 17 00:00:00 2001 From: ineanto Date: Mon, 30 Jun 2025 22:02:09 +0200 Subject: [PATCH 2/2] refactor: remove the print --- .../java/xyz/ineanto/nicko/appearance/AppearanceManager.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java b/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java index 0624784..cd22e5f 100644 --- a/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java +++ b/src/main/java/xyz/ineanto/nicko/appearance/AppearanceManager.java @@ -54,8 +54,6 @@ public class AppearanceManager { if (skinChange) { final ActionResult propertiesUpdateResult = packetSender.updatePlayerProfileProperties(); - System.out.println(player.getPlayerProfile().getName()); - if (propertiesUpdateResult.isError()) { return resetWithoutUpdate(); }